Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows warnings #331

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix Windows warnings #331

merged 1 commit into from
Oct 31, 2024

Conversation

FranzBusch
Copy link
Member

Motivation

Fixes #330.

We had a few warnings since we were using deprecated POSIX methods on Windows.

Modification

Moves to the non-deprecated underscored methods.

Result

Windows build is warning free.

# Motivation

Fixes #330.

We had a few warnings since we were using deprecated POSIX methods on Windows.

# Modification

Moves to the non-deprecated underscored methods.

# Result

Windows build is warning free.
@FranzBusch FranzBusch added the 🔨 semver/patch No public API change. label Oct 31, 2024
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktoso
Copy link
Member

ktoso commented Oct 31, 2024

windows stable swift are now required

@FranzBusch FranzBusch merged commit 1efe6f8 into main Oct 31, 2024
26 of 27 checks passed
@FranzBusch FranzBusch deleted the fb-windows-warnings branch October 31, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Windows build warnings
2 participants