Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix garbage component issue of ruby-saml and rexml #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klouvas
Copy link

@klouvas klouvas commented Sep 6, 2021

Issue: #201

@adamstegman
Copy link
Collaborator

Hi @klouvas, thanks for the contribution! I don't think this requires a fix on our end—applications can update their version of ruby-saml without needing to update this gem.

@klouvas klouvas changed the title Fix garbace component issue of ruby-saml and rexml Fix garbage component issue of ruby-saml and rexml Sep 6, 2021
@klouvas
Copy link
Author

klouvas commented Sep 7, 2021

@adamstegman It could be resolved by manually bumping the ruby-saml or updating the rexml gem. Wouldn't it be better to upgrade the ruby-xml of the devise_saml_authenticatable to latest stable to resolve all related issue and keep the gem dependencies up to date?

@adamstegman
Copy link
Collaborator

If there's a security issue, definitely! But for anything else, it's not our responsibility, and in fact we'd be breaking compatibility with applications using older versions of ruby-saml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants