Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compute descriptor to include dependencies and accept implicit project/locations #199

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

timburks
Copy link
Contributor

@timburks timburks commented Jun 5, 2023

While working on a gRPC sample, I noticed that compute descriptor was still requiring project/location prefixes and was not including dependencies (protoc --include_imports), which is needed by many downstream tools (e.g. API Gateway). This fixes both and updates the command to use RunE.

Also, this command is not tested: #200

@timburks timburks merged commit 98ee697 into apigee:main Jun 5, 2023
@timburks timburks deleted the descriptor branch September 18, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants