Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6146] Replace 'application/zpln' with '.zpln' in 'accept' attribute of file importer #4895

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Charlie91
Copy link
Contributor

@Charlie91 Charlie91 commented Nov 4, 2024

What is this PR for?

Currently, in new UI, it's not that easy to import notes fron .zpln files, since by default file importer only looks for .json files. The bug was reproduced in both Win10 and MacOs

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6146

Copy link
Contributor

@tbonelee tbonelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It works as expected.

@Charlie91
Copy link
Contributor Author

the gif that shows what's broken
https://www.imghippo.com/i/fGng3497krU.gif

@pan3793 pan3793 changed the title [ZEPPELIN-6146] Replace 'application/zpln' with '.zpln' in 'accept' a… [ZEPPELIN-6146] Replace 'application/zpln' with '.zpln' in 'accept' attribute of file importer Nov 11, 2024
@Reamer Reamer merged commit 80c8825 into apache:master Nov 11, 2024
17 checks passed
asfgit pushed a commit that referenced this pull request Nov 11, 2024
…ttribute of file importer

### What is this PR for?
Currently, in new UI, it's not that easy to import notes fron .zpln files, since by default file importer only looks for .json files. The bug was reproduced in both Win10 and MacOs

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6146

Closes #4895 from Charlie91/change-fileimporter-accept-rule.

Signed-off-by: Philipp Dallig <[email protected]>
(cherry picked from commit 80c8825)
Signed-off-by: Philipp Dallig <[email protected]>
@Reamer
Copy link
Contributor

Reamer commented Nov 11, 2024

Merged into master/branch-0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants