[ZEPPELIN-6145] Remove useless message type in Terminal Interpreter #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot evaluate this change. Who can carry out a review here? |
tbonelee
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Could you remove commented method call for app.onTerminalInit() in the file for clarity?
pan3793
approved these changes
Nov 11, 2024
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2024
### What is this PR for? This PR removes `TERMINAL_INIT` to simplify the code. `TERMINAL_INIT`, one of the WebSocket message types in the terminal interpreter, looks unused and redundant with `TERMINAL_READY` ### What type of PR is it? Refactoring ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6145 ### How should this be tested? * Execute terminal interpreter ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4894 from seung-00/ZEPPELIN-6145. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit 0a7f861) Signed-off-by: Philipp Dallig <[email protected]>
|
Merged into master/branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR removes
TERMINAL_INITto simplify the code.TERMINAL_INIT, one of the WebSocket message types in the terminal interpreter, looks unused and redundant withTERMINAL_READYWhat type of PR is it?
Refactoring
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6145
How should this be tested?
Screenshots (if appropriate)
Questions: