[ZEPPELIN-6140] Add logs to the runParagraph method #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
reviewed
Nov 5, 2024
| if (note == null) { | ||
| LOGGER.info("Failed to run paragraph: Note is null"); |
There was a problem hiding this comment.
Suggested change
| LOGGER.info("Failed to run paragraph: Note is null"); | |
| LOGGER.info("Failed to run paragraph {}, Note is null", paragraphId); |
There was a problem hiding this comment.
@Reamer
I have completed this task. :)
| return false; | ||
| } | ||
| LOGGER.info("Start to run paragraph: {} of note: {}", paragraphId, note.getId()); | ||
| if (!checkPermission(note.getId(), Permission.RUNNER, Message.OP.RUN_PARAGRAPH, context, callback)) { | ||
| LOGGER.info("Permission check failed for running paragraph: {} of note: {}", paragraphId, note.getId()); |
There was a problem hiding this comment.
Suggested change
| LOGGER.info("Permission check failed for running paragraph: {} of note: {}", paragraphId, note.getId()); | |
| LOGGER.info("Permission check failed for running paragraph {} of note {}", paragraphId, note.getId()); |
There was a problem hiding this comment.
@Reamer
I have completed this task. :)
| Paragraph p = note.getParagraph(paragraphId); | ||
|
|
There was a problem hiding this comment.
@Reamer
I have completed this task. :)
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
Show resolved
Hide resolved
| if (p == null) { | ||
| LOGGER.info("Paragraph with ID {} not found in note: {}", paragraphId, note.getId()); |
There was a problem hiding this comment.
Suggested change
| LOGGER.info("Paragraph with ID {} not found in note: {}", paragraphId, note.getId()); | |
| LOGGER.info("Paragraph {} not found in note {}", paragraphId, note.getId()); |
There was a problem hiding this comment.
@Reamer
I have completed this task. :)
asfgit
pushed a commit
that referenced
this pull request
Nov 11, 2024
### What is this PR for? This involves revising the description of the runParagraph method and adding clear logs for each step. ### What type of PR is it? Improvement ### Todos * [x] - NotebookService.java ### What is the Jira issue? * https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-6140 ### How should this be tested? * Debugging ### Screenshots (if appropriate)  ### Questions: * Does the license files need to update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Closes #4889 from ParkGyeongTae/add-logs-to-the-runparagraph-method. Signed-off-by: Philipp Dallig <[email protected]>
|
Merged into master/branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This involves revising the description of the runParagraph method and adding clear logs for each step.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: