[ZEPPELIN-6125] Enable updates on the same branch using dev/checkout_zeppelin_pr.sh #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
pushed a commit
that referenced
this pull request
Oct 7, 2024
…zeppelin_pr.sh (Reopening to link this github PR issues to the jira issue) ### What is this PR for? The `dev/checkout_zeppelin_pr.sh` script is useful for locally checking out PR commits. Currently, it fetches the PR and checks out a new branch. However, if the script is run while already on the target branch, the updates are not reflected because `git checkout` does not move the `HEAD` when the current branch is already checked out. To resolve this, the script has been updated to use `git pull` instead when the current branch is already checked out. ### What type of PR is it? Improvement ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-6125 * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4870 from tbonelee/enhance-checkout-script. Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 45c981b) Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Reopening to link this github PR issues to the jira issue)
What is this PR for?
The
dev/checkout_zeppelin_pr.shscript is useful for locally checking out PR commits.Currently, it fetches the PR and checks out a new branch.
However, if the script is run while already on the target branch, the updates are not reflected because
git checkoutdoes not move theHEADwhen the current branch is already checked out.To resolve this, the script has been updated to use
git pullinstead when the current branch is already checked out.What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: