[ZEPPELIN-6077] Remove raw types for AngularObject #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review required. |
Reamer
commented
Sep 16, 2024
| @@ -134,7 +134,7 @@ abstract class AbstractAngularElem(val interpreterContext: InterpreterContext, | |||
| Text(s"${functionName}=${functionName} + 1"), | |||
| Null) | |||
|
|
|||
| val angularObject = addAngularObject(functionName, 0) | |||
| val angularObject = addAngularObject(functionName, Int.box(0)) | |||
There was a problem hiding this comment.
This is the only place where I am not sure that this is completely correct.
| @@ -70,7 +70,7 @@ abstract class AbstractAngularElem(val interpreterContext: InterpreterContext, | |||
| * @return | |||
| */ | |||
| @ZeppelinApi | |||
| def model(name: String, value: Any): AbstractAngularElem = { | |||
| def model(name: String, value: AnyRef): AbstractAngularElem = { | |||
There was a problem hiding this comment.
AnyRef is the same as object.
https://docs.scala-lang.org/tour/unified-types.html#scala-type-hierarchy
|
Review required. |
Reamer
force-pushed
the
raw_type
branch
2 times, most recently
from
1deca4a to
b21c947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pull request removes the raw use of the AngularObject. The generic version has been removed. AngularObject now contains an object reference.
As a result, warnings from the IDE due to raw use disappear. The code is also easier to read.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Questions: