Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce missing details issue in the access log module #168

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

mrproliu
Copy link
Contributor

Under high traffic conditions, logs like "cannot find full detail events for HTTP/1.x protocol ..." may frequently appear.
This is due to potential order inconsistencies and data alignment issues between multiple queues when using PERF_ARRAY at the underlying level.

Therefore, this PR introduces the following aspects to address these issues:

  1. There was a data race issue in multi-threaded environments during partial protocol parsing of HTTP/1.x.
  2. Added a retry feature for obtaining detailed events to prevent problems caused by slow data reception.

@mrproliu mrproliu added the enhancement New feature or request label Dec 13, 2024
@mrproliu mrproliu added this to the 0.8.0 milestone Dec 13, 2024
@mrproliu mrproliu marked this pull request as draft December 13, 2024 13:48
@mrproliu mrproliu marked this pull request as ready for review December 13, 2024 15:16
@mrproliu mrproliu requested a review from wu-sheng December 13, 2024 15:16
@wu-sheng wu-sheng merged commit 089d9c9 into main Dec 16, 2024
28 checks passed
@wu-sheng wu-sheng deleted the missing-details branch December 16, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants