Improve the build of skywalking-rover

apache · Nov 27, 2024 · bcb19a1 · bcb19a1
1 parent 6997e66
commit bcb19a1
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -7,6 +7,8 @@ Release Notes.
 #### Features
 * Separate multiple process for reading connection information in the access log module.
 * Add a delay time before delete the connection in the access log module.
+* Fix context structs parameters for tracepoint programs.
+* Improve the build of skywalking-rover by adding some options.
 
 #### Bug Fixes
 * Fix the base image cannot run in the arm64.

diff --git a/docker/Dockerfile.build b/docker/Dockerfile.build
@@ -23,8 +23,6 @@ WORKDIR /src
 
 COPY . .
 
-ENV CGO_ENABLED=0
-
 RUN VERSION=$VERSION make btfgen && make linux
 RUN mv /src/bin/skywalking-rover-${VERSION}-linux-* /src/bin/skywalking-rover
 
@@ -37,4 +35,4 @@ WORKDIR /skywalking
 COPY --from=build /src/bin/skywalking-rover /
 COPY --from=build /src/configs /skywalking/configs
 
-CMD ["/skywalking-rover", "start", "--config", "/skywalking/configs/rover_configs.yaml"]
+CMD ["/skywalking-rover", "start", "--config", "/skywalking/configs/rover_configs.yaml"]
diff --git a/docker/Dockerfile.debug b/docker/Dockerfile.debug
@@ -23,8 +23,6 @@ WORKDIR /src
 
 COPY . .
 
-ENV CGO_ENABLED=0
-
 RUN go install github.com/go-delve/delve/cmd/dlv@latest
 
 RUN VERSION=$VERSION make generate && make linux
@@ -42,4 +40,4 @@ COPY --from=build /src/configs /skywalking/configs
 
 EXPOSE 40000
 
-CMD ["/dlv", "--listen=:40000", "--headless=true", "--api-version=2", "--log", "--accept-multiclient", "exec", "/skywalking-rover", "--", "start", "--config", "/skywalking/configs/rover_configs.yaml"]
+CMD ["/dlv", "--listen=:40000", "--headless=true", "--api-version=2", "--log", "--accept-multiclient", "exec", "/skywalking-rover", "--", "start", "--config", "/skywalking/configs/rover_configs.yaml"]
diff --git a/scripts/build/build.mk b/scripts/build/build.mk
@@ -19,7 +19,7 @@
 BINARY = skywalking-rover
 
 OUT_DIR = bin
-GO_BUILD_FLAGS = -v
+GO_BUILD_FLAGS = -buildvcs=false -v
 GO_BUILD_LDFLAGS = -X main.version=$(VERSION)
 
 PLATFORMS := linux
@@ -36,7 +36,7 @@ deps:
 .PHONY: $(PLATFORMS)
 $(PLATFORMS): deps
 	mkdir -p $(OUT_DIR)
-	GOOS=$(os) GOARCH=$(ARCH) $(GO_BUILD) $(GO_BUILD_FLAGS) -ldflags "$(GO_BUILD_LDFLAGS)" -o $(OUT_DIR)/$(BINARY)-$(VERSION)-$(os)-$(ARCH) ./cmd
+	CGO_ENABLED=0 GOOS=$(os) GOARCH=$(ARCH) $(GO_BUILD) $(GO_BUILD_FLAGS) -ldflags "$(GO_BUILD_LDFLAGS)" -o $(OUT_DIR)/$(BINARY)-$(VERSION)-$(os)-$(ARCH) ./cmd
 
 .PHONY: build
 build: linux