Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust agent server to raw error and cli error display #472

Merged
merged 14 commits into from
Nov 23, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Nov 22, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

#459

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the pitr solutions of pitr label Nov 22, 2023
@mlycore mlycore changed the title Error msg refactor: adjust agent server to raw error and cli error display Nov 22, 2023
@mlycore mlycore added this to the 0.4.0 milestone Nov 22, 2023
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 909 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (4fe8a51) 36.83%.
Report is 224 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/agent/internal/pkg/opengauss.go 7.22% 77 Missing ⚠️
pitr/cli/internal/cmd/delete.go 67.45% 43 Missing and 12 partials ⚠️
pitr/cli/pkg/prettyoutput/progress.go 8.51% 43 Missing ⚠️
pitr/cli/internal/pkg/local-storage.go 11.11% 37 Missing and 3 partials ⚠️
pitr/cli/internal/cmd/backup.go 70.58% 33 Missing and 2 partials ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
pitr/cli/internal/cmd/common.go 77.77% 16 Missing and 8 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   39.71%   36.83%   -2.88%     
==========================================
  Files          51       60       +9     
  Lines        6083     6925     +842     
==========================================
+ Hits         2416     2551     +135     
- Misses       3448     4131     +683     
- Partials      219      243      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taojintianxia taojintianxia merged commit 8ce3577 into apache:main Nov 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants