Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user approve prompt to delete #466

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Nov 16, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • Add hided file filter
  • Add user approve prompt to delete
  • Refactor backup delete and restore delete
  • Return if user input N when backup

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the pitr solutions of pitr label Nov 16, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 810 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (8dcf177) 36.66%.
Report is 196 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/cli/internal/cmd/delete.go 59.37% 40 Missing and 12 partials ⚠️
pitr/agent/internal/pkg/opengauss.go 2.56% 38 Missing ⚠️
pitr/cli/internal/pkg/local-storage.go 3.03% 31 Missing and 1 partial ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
...ere-operator/pkg/kubernetes/container/container.go 31.25% 22 Missing ⚠️
shardingsphere-operator/pkg/kubernetes/helpers.go 46.15% 20 Missing and 1 partial ⚠️
pitr/agent/internal/handler/restore.go 0.00% 20 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   39.71%   36.66%   -3.06%     
==========================================
  Files          51       61      +10     
  Lines        6083     6781     +698     
==========================================
+ Hits         2416     2486      +70     
- Misses       3448     4053     +605     
- Partials      219      242      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlycore mlycore added this to the 0.4.0 milestone Nov 16, 2023
@tristaZero tristaZero merged commit c5da93a into apache:main Nov 16, 2023
8 checks passed
@mlycore mlycore deleted the refactor-delete branch November 16, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants