Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dbname and status message in healthcheck #457

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Nov 14, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the pitr solutions of pitr label Nov 14, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 875 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (acee826) 36.31%.
Report is 191 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...rdingsphere-operator/pkg/kubernetes/pod/builder.go 0.00% 118 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/agent/internal/pkg/opengauss.go 2.70% 36 Missing ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
...hardingsphere-operator/pkg/kubernetes/resources.go 0.00% 28 Missing ⚠️
...ere-operator/pkg/kubernetes/container/container.go 31.25% 22 Missing ⚠️
shardingsphere-operator/pkg/kubernetes/helpers.go 46.15% 20 Missing and 1 partial ⚠️
...perator/pkg/controllers/compute_node_controller.go 0.00% 20 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   39.71%   36.31%   -3.41%     
==========================================
  Files          51       59       +8     
  Lines        6083     6617     +534     
==========================================
- Hits         2416     2403      -13     
- Misses       3448     3987     +539     
- Partials      219      227       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaigorJiang RaigorJiang added this to the 0.4.0 milestone Nov 14, 2023
@RaigorJiang RaigorJiang merged commit 0042f2c into apache:main Nov 14, 2023
8 checks passed
@mlycore mlycore deleted the fix-og-auth branch November 14, 2023 11:34
mlycore added a commit to mlycore/shardingsphere-on-cloud that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants