Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase timeout on flaky test #796

Merged
merged 1 commit into from
Nov 21, 2023
Merged

increase timeout on flaky test #796

merged 1 commit into from
Nov 21, 2023

Conversation

pjfanning
Copy link
Contributor

see #795

He-Pin

This comment was marked as duplicate.

Sign in to view

He-Pin
He-Pin approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mdedetrich
mdedetrich approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I also think this is a good candidate to backport to 1.0.x branch since its a test improvement.

@pjfanning pjfanning merged commit 64d9d70 into apache:main Nov 21, 2023
17 of 18 checks passed
@pjfanning pjfanning mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxnu-liguobin jxnu-liguobin jxnu-liguobin approved these changes

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin He-Pin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pjfanning @He-Pin @mdedetrich @jxnu-liguobin