[MRELEASE-1089] Reduce the default tag format to the project version only

[michael-o]

This closes #122

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[pzygielo]

Will similar be applied to

maven-release/maven-release-manager/src/main/java/org/apache/maven/shared/release/policies/DefaultNamingPolicy.java

Lines 34 to 44 in 8cc2f45

	* @since 3.0.0-M5
	*/
	@Singleton
	@Named
	public class DefaultNamingPolicy implements NamingPolicy
	{
	@Override
	public NamingPolicyResult getName( NamingPolicyRequest request )
	throws PolicyException
	{
	return new NamingPolicyResult().setName( request.getArtifactId() + "-" + request.getVersion() );

?

[michael-o]

Will similar be applied to

maven-release/maven-release-manager/src/main/java/org/apache/maven/shared/release/policies/DefaultNamingPolicy.java

Lines 34 to 44 in 8cc2f45

	* @since 3.0.0-M5
	*/
	@Singleton
	@Named
	public class DefaultNamingPolicy implements NamingPolicy
	{
	@Override
	public NamingPolicyResult getName( NamingPolicyRequest request )
	throws PolicyException
	{
	return new NamingPolicyResult().setName( request.getArtifactId() + "-" + request.getVersion() );

?

Oh, very nice catch...
Yes, it should be consistent throughout, no?

[michael-o]

@pzygielo Done. Thank you!

[hboutemy]

please everywhere (even the commit message), please rephrase "reduce the tag format" to "reduce the default tag format"

on changing the default, I don't like it because it has implicit effect

I'd better add an explicit page showing how to change the tag name

[michael-o]

please everywhere (even the commit message), please rephrase "reduce the tag format" to "reduce the default tag format"

on changing the default, I don't like it because it has implicit effect

I'd better add an explicit page showing how to change the tag name

Done.

[kwin]

I would also not change the default but rather document only how to change it. Changing it will lead to regressions for some users, where multiple releases are triggered from the same repo.

[michael-o]

I would also not change the default but rather document only how to change it. Changing it will lead to regressions for some users, where multiple releases are triggered from the same repo.

It is a major version after all and we'd provide an update documentation for this. Conventions change. If people blindly update and don't check the changelog means we will never be able to move forward.

@cstamas

[kwin]

The old default may be too verbose but will IMHO never lead to a release failure while the new proposed default may fail. Therefore I consider the old default better!

[jgangemi]

i’d like to second keeping the old format as default. we rely on this format for other tooling and needing to make changes on either side would be cumbersome.

[michael-o]

The old default may be too verbose but will IMHO never lead to a release failure while the new proposed default may fail. Therefore I consider the old default better!

That is an argument. I will on docs before I will consider this.