[MENFORCER-507] Add xsltLocation parameter to ExternalRules #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
force-pushed
the
240701-xsltLocation
branch
from
3a7e286 to
5861bb1
Compare
ppalaga
changed the title
|
Would anybody like to review? @slawekjaranowski maybe? |
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/ExternalRules.java
Show resolved
Hide resolved
ppalaga
force-pushed
the
240701-xsltLocation
branch
from
5861bb1 to
1cb5e73
Compare
ppalaga
force-pushed
the
240701-xsltLocation
branch
from
1cb5e73 to
ec9455a
Compare
|
|
Would you like to re-review, @slawekjaranowski ? |
slawekjaranowski
approved these changes
Aug 5, 2024
slawekjaranowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
https://issues.apache.org/jira/browse/MENFORCER-507
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like
[MENFORCER-XXX] - Fixes bug in ApproximateQuantilesWrite a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
You have run the integration tests successfully (
mvn -Prun-its clean verify).I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004