Revert to console output when configuration file is missing in examples #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nted configuration examples
|
It looks like that message will still be printed out, is that correct? I want to make sure that it will still indicate to the user somehow that configuration was not successful, since otherwise it could look like it succeeded when it actually failed. |
|
This PR only changes the documented examples (i.e. it is in the user's domain). The return value of *::configure tells the user that configuration was not successful. They could handle the failure differently. An important result of this PR is to show that the failure to configure is available in the return value of *::configure. A separate PR could be raised to configure console logging after that message is printed out if you think it appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending logging events to the console seems to be more useful than seeing the message
on the console.