Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24045 Sql. Replace UUID.randomUUID() with custom generator for query id #4935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

korlov42
Copy link
Contributor

https://issues.apache.org/jira/browse/IGNITE-24045

Result of the benchmark on my laptop (MBP M3) as follow:

Before
Benchmark                         (clusterSize)  (fsync)  Mode  Cnt   Score   Error  Units
SelectBenchmark.sqlGet_1_thread               1    false  avgt   20   6.061 ± 0.137  us/op
SelectBenchmark.sqlGet_4_threads              1    false  avgt   20   8.773 ± 0.848  us/op
SelectBenchmark.sqlGet_8_threads              1    false  avgt   20  16.954 ± 1.540  us/op

After
Benchmark                         (clusterSize)  (fsync)  Mode  Cnt   Score   Error  Units
SelectBenchmark.sqlGet_1_thread               1    false  avgt   20   5.758 ± 0.099  us/op
SelectBenchmark.sqlGet_4_threads              1    false  avgt   20   8.473 ± 0.958  us/op
SelectBenchmark.sqlGet_8_threads              1    false  avgt   20  15.295 ± 1.334  us/op

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants