feat: manifest support delete #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baojinri
reviewed
Dec 17, 2024
| @@ -399,7 +395,7 @@ impl From<SnapshotRecordV1> for SstFile { | |||
|
|
|||
| struct Snapshot { | |||
| header: SnapshotHeader, | |||
| inner: Bytes, | |||
| records: Vec<SnapshotRecordV1>, | |||
There was a problem hiding this comment.
Using SnapshotRecordV1 here, we lose the optimized manifest structure in #1600
There was a problem hiding this comment.
The old format can't support SST delete.
baojinri
reviewed
Dec 18, 2024
baojinri
approved these changes
Dec 18, 2024
baojinri
pushed a commit
that referenced
this pull request
Dec 18, 2024
## Rationale Followup #1610, to make manifest more modular. ## Detailed Changes ## Test Plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When compact finished, we need to delete the old input sst and expired sst.
Detailed Changes
ManifestUpdatestruct.Test Plan
CI