-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support horaedb submit compaction task to remote #1563
Conversation
e6cfb01
to
2f7f3c4
Compare
2f7f3c4
to
317d248
Compare
It looks good to me. I am checking it in my local, let's merge it after the double check! |
I check your commits in my local. I think we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @LeslieKid |
Rationale
The subtask to support compaction offloading. See #1545
Detailed Changes
Compaction node support remote compaction service
Define
CompactionServiceImpl
to support compaction rpc service.Introduce
NodeType
to distinguish compaction node and horaedb node. Enable the deployment of compaction node.Impl
compaction_client
for horaedb node to access remote compaction node.Horaedb node support compaction offload
compaction_mode
in analytic engine'sConfig
to determine whether exec compaction offload or not.CompactionNodePicker
trait, supporting get remote compaction node info.RemoteCompactionRunner
, supporting pick remote node and pass compaction task to the node.example-cluster-n.toml
) to explain how to deploy a cluster supporting compaction offload.Test Plan