Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request sets the
GDK_BACKEND
environment variable is explicitly set tox11
when wayland is detected. This forces GTK-based HOP to use X11 rendering, making it compatible in Wayland sessions. The rest of the Linux-specific logic related to classpath and architecture is preserved as-is.Below is a screenshot showing the issue resolved when
GDK_BACKEND=x11
is applied and the mouse is hovered over the hop line near the success instead of the top-left corner.NOTE: This pull request also addresses related issues spotted when hovering over pipeline arrows, the welcome dialog and other dialogs appearing in the top-left of the screen.
Additional Information:
The issue was reproduced on Fedora 39 running Wayland and goes away with the attached pull request.
The issue appears to be related to SWT/GDK when on Wayland (see eclipse tickets below).
Can't confirm if related or if it resolves issue #4441.
In addition, an observation with the dialogs in that adding
ON_TOP
to the style mitigates, but does not eliminate the issue. This was obtained from eclipse-platform/eclipse.platform.swt#790.shell = new Shell(parent, SWT.ON_TOP | SWT.DIALOG_TRIM | SWT.CLOSE | SWT.RESIZE | SWT.MAX);
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:check
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i
.addresses #123
), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.