Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect tooltip position #4252 #4720

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

ep9io
Copy link
Contributor

@ep9io ep9io commented Dec 17, 2024

The pull request sets the GDK_BACKEND environment variable is explicitly set to x11 when wayland is detected. This forces GTK-based HOP to use X11 rendering, making it compatible in Wayland sessions. The rest of the Linux-specific logic related to classpath and architecture is preserved as-is.

Below is a screenshot showing the issue resolved when GDK_BACKEND=x11 is applied and the mouse is hovered over the hop line near the success instead of the top-left corner.

image

NOTE: This pull request also addresses related issues spotted when hovering over pipeline arrows, the welcome dialog and other dialogs appearing in the top-left of the screen.

Additional Information:

The issue was reproduced on Fedora 39 running Wayland and goes away with the attached pull request.

The issue appears to be related to SWT/GDK when on Wayland (see eclipse tickets below).

Can't confirm if related or if it resolves issue #4441.

In addition, an observation with the dialogs in that adding ON_TOP to the style mitigates, but does not eliminate the issue. This was obtained from eclipse-platform/eclipse.platform.swt#790.

shell = new Shell(parent, SWT.ON_TOP | SWT.DIALOG_TRIM | SWT.CLOSE | SWT.RESIZE | SWT.MAX);


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Tristan Everitt added 4 commits December 10, 2024 00:12
# Conflicts:
#	plugins/transforms/languagemodelchat/src/main/java/org/apache/hop/pipeline/transforms/languagemodelchat/internals/ui/models/AbstractModelComposite.java
@ep9io
Copy link
Contributor Author

ep9io commented Dec 17, 2024

Only after noticing that the PR also included 26e38a5 and 00a3249, which should not cause an issue. I branched off a development branch that I keep locally.

@hansva
Copy link
Contributor

hansva commented Dec 17, 2024

awesome @ep9io !

@ep9io
Copy link
Contributor Author

ep9io commented Dec 17, 2024

It's really only a workaround. The issue with not running properly under Wayland is still there, however.

@hansva
Copy link
Contributor

hansva commented Dec 17, 2024

Yes, but reading the tickets it seems like an SWT issue so we can't really do much about it on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants