Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helix-front] Minor version bump to 1.7.0 #2676

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

GrantPSpencer
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:
    N/A

Description

Bump helix-front version, I should have done this in my previous PR - sorry!

(Write a concise description including what, why, how)

Tests

  • The following tests are written for this issue:

$ yarn test

Test Suites: 9 skipped, 35 passed, 35 of 44 total
Tests:       10 skipped, 38 passed, 48 total
Snapshots:   0 total
Time:        36.123 s
Ran all test suites.
✨  Done in 47.67s.

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@desaikomal desaikomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@junkaixue junkaixue merged commit 7c86f4a into apache:master Feb 13, 2024
2 checks passed
@desaikomal
Copy link
Contributor

i was kind of surprised to see old thread :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants