Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealmAware client change for rest cache - support recursive persist listener #2660

Closed

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Oct 13, 2023

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2659

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This change adds support for recursive persist listener in realmAware ZkClient. As rest client cache will use recursive persist listener for ZK change events.

Tests

  • The following tests are written for this issue:
    TestFederatedZkClient.testFederatedZkClientWithPersistListener

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu marked this pull request as ready for review October 14, 2023 05:50
@asfgit asfgit force-pushed the ApplicationClusterManager branch from 7fca663 to 5f1a3f7 Compare October 17, 2023 20:25
@asfgit asfgit force-pushed the ApplicationClusterManager branch 2 times, most recently from 5d6396e to 3775e3d Compare December 13, 2023 20:47
@junkaixue
Copy link
Contributor

Is this still a valid change?

@xyuanlu xyuanlu closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants