-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor stoppable check logic for enhanced zone analysis #2654
Merged
xyuanlu
merged 4 commits into
apache:ApplicationClusterManager
from
MarkGaox:ApplicationClusterManager
Oct 24, 2023
Merged
Refactor stoppable check logic for enhanced zone analysis #2654
xyuanlu
merged 4 commits into
apache:ApplicationClusterManager
from
MarkGaox:ApplicationClusterManager
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
force-pushed
the
ApplicationClusterManager
branch
from
October 17, 2023 20:25
7fca663
to
5f1a3f7
Compare
MarkGaox
force-pushed
the
ApplicationClusterManager
branch
from
October 18, 2023 18:19
5d93639
to
98362eb
Compare
xyuanlu
reviewed
Oct 19, 2023
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Show resolved
Hide resolved
xyuanlu
approved these changes
Oct 23, 2023
This PR is approved by @xyuanlu . Thanks! |
3 tasks
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2023
Refactor the zone-based stoppable check logic and add support to randomly select zone order for the zone-based stoppable check.
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2023
Refactor the zone-based stoppable check logic and add support to randomly select zone order for the zone-based stoppable check.
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2023
Refactor the zone-based stoppable check logic and add support to randomly select zone order for the zone-based stoppable check.
3 tasks
xyuanlu
pushed a commit
that referenced
this pull request
Dec 20, 2023
Refactor the zone-based stoppable check logic and add support to randomly select zone order for the zone-based stoppable check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
Tests
mvn test -Dtest=TestInstancesAccessor
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)