Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helix-UI instance resource view misformatting on direct page load #2652

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

GrantPSpencer
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2651

Resource view for instance does not get formatted correctly when you load it directly via the URL.
https://<helix_ui_url>///instances/<instance_name>/resources

When you access the instance resources page directly via the url or by refreshing the page, the datatable's row widths do not seem to get properly configured and are instead set to 50px. Seems like the UI relies on the loaded content to determine the width of the "datatable-row-detail," and some interaction is causing the width to be determined prior to the content being populated..

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Force the datatable rows to use 100% of the parent width

Screenshot 2023-10-10 at 6 26 55 PM

The only negative of this change would be that if the page is stretched over a very long screen, the row would still use the entire width allocated to it and would be stretched as a result - the space between the "Partition" and "CurrentState" columns/values would increase.

Tests

  • The following tests are written for this issue:

Deployed helix front locally:
yarn build
yarn start

  • The following is the result of the "mvn test" command on the appropriate module:

N/A.. No java code changes, only to the styling sheet (.scss)

@junkaixue
Copy link
Contributor

@hivivo Could you please review?

@GrantPSpencer
Copy link
Contributor Author

Pull request approved by @hivivo
Commit message: Force resource view to use 100% parent container width

@junkaixue junkaixue merged commit 1a4da73 into apache:master Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants