Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude on-operation instance from computing min active replica in WAGED #2624

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Sep 20, 2023

Exclude on-operation instance from computing min active replica in WAGED.

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Merge feature branch to master

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Merge feature branch to master

Tests

  • The following tests are written for this issue:

Please refer to original PR.

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

…GED. (#2621)

Exclude on-operation instance from computing min active replica in WAGED.
@xyuanlu xyuanlu marked this pull request as ready for review September 20, 2023 18:32
@xyuanlu
Copy link
Contributor Author

xyuanlu commented Sep 21, 2023

This PR is ready to be merged. Approved by @zpinto and @MarkGaox // Thanks!

@xyuanlu xyuanlu merged commit 79cefa3 into master Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants