Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown exec on KubernetesTaskRunner stop #17601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgew5656
Copy link
Contributor

Fixes a issue where the KubernetesTaskRunner still tracks task status after the overlord it is running on has lost leadership.

Description

The KubernetesTaskRunner doesn't actually do anything to stop watching running tasks in its stop method(), so the threads watching each task continue running doTask(). In this situation, the task queue is already shutdown, so the only thing that happens is the 'phantom' KubernetesTaskRunner sending notifications to its task queue that get ignored and potentially task logs getting double uploaded.

This is still not ideal, so we should shutdown the exec Executor in the stop method. This won't stop any of the tasks (they're running on k8s), but will stop the overlord's management of these tasks, which is the correct behavior.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Fixed a bug with overlord shutdown in mmless mode.

Release note

Bugfix with mmless ingestion.

Key changed/added classes in this PR
  • KubernetesTaskRunner

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants