Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate scalar functions (array) documentation 1/3 #13928

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

Chen-Yuan-Lai
Copy link
Contributor

@Chen-Yuan-Lai Chen-Yuan-Lai commented Dec 27, 2024

Which issue does this PR close?

Part of #13671 .

Rationale for this change

What changes are included in this PR?

As discussed in #13671 , this PR will migrate the parts of builtin array functions documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

@Omega359
Copy link
Contributor

Can you take a look at the Clippy failure? Seems to be just an unused import

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 28, 2024
@Chen-Yuan-Lai Chen-Yuan-Lai force-pushed the migrate_scalar_functions_array_1/3 branch from a8310d2 to 0a84fa7 Compare December 28, 2024 16:21
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Chen-Yuan-Lai I think we got a lot fixed in the doc with this PR

Copy link
Contributor

@Omega359 Omega359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to see all the documentation fixes

+-----------------------------+
| true |
+-----------------------------+
> select array_has_any([1, 2, 3], [3, 4]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree -- thank you @Chen-Yuan-Lai for your diligence while porting the code to also fix the docs

@alamb alamb merged commit 6a92870 into apache:main Dec 29, 2024
29 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 29, 2024

Thanks @Chen-Yuan-Lai and @comphead and @Omega359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants