doc-gen: migrate scalar functions (string) documentation 2/4 #13925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you run the doc generation script prior to pushing this change? The doc diff seems ... odd |
github-actions
bot
added
the
documentation
comphead
reviewed
Dec 29, 2024
| @@ -1697,8 +1697,8 @@ upper(str) | |||
|
|
|||
| **Related functions**: | |||
|
|
|||
| - [initcap](#initcap) | |||
| - [lower](#lower) | |||
There was a problem hiding this comment.
hm, why we have this change? 🤔 its not critical but last revision was better as it sorted
There was a problem hiding this comment.
Ah, I overlooked the sorting part. You're right. I'll revert it back. Thanks for catching this! 👍
comphead
reviewed
Dec 30, 2024
| @@ -971,8 +971,8 @@ concat_ws(separator, str[, ..., str_n]) | |||
|
|
|||
| #### Arguments | |||
|
|
|||
| - **separator**: Separator to insert between concatenated strings. | |||
| - **str**: String expression to operate on. Can be a constant, column, or function, and any combination of operators. | |||
There was a problem hiding this comment.
I think separator should come first in order like it is in the function signature
There was a problem hiding this comment.
I tried changing the order between argument and standard argument in user_doc(), but the documentation order didn't change. Is the order of content sections fixed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #13671 .
Rationale for this change
What changes are included in this PR?
As discussed in #13671 , this PR will migrate the parts of builtin string functions documentation that currently support migration.
Are these changes tested?
Are there any user-facing changes?