Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate scalar functions (datetime) documentation 2/2 #13921

Merged

Conversation

Chen-Yuan-Lai
Copy link
Contributor

@Chen-Yuan-Lai Chen-Yuan-Lai commented Dec 27, 2024

Which issue does this PR close?

Part of #13671 .

Rationale for this change

What changes are included in this PR?

As discussed in #13671 , this PR will migrate the parts of builtin datetime functions documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 29, 2024
@comphead
Copy link
Contributor

Something wrong here, looks like doc macros is not working in this PR

@comphead
Copy link
Contributor

Looks like the doc macros doesn't work for this PR for some functions

| 2023-01-31 |
+-----------------------------+
+-------------------------------+
| to_date(Utf8(\"2023-01-31\")) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the slash is not needed

| 2023-01-31 |
+---------------------------------------------------------------+
+---------------------------------------------------------------------+
| to_date(Utf8(\"2023/01/31\"),Utf8(\"%Y-%m-%d\"),Utf8(\"%Y/%m/%d\")) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@comphead
Copy link
Contributor

I think we are very close

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @Chen-Yuan-Lai 1 done some more to go :)

@comphead comphead merged commit 9eca7d1 into apache:main Dec 31, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants