-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc-gen: migrate scalar functions (datetime) documentation 2/2 #13921
doc-gen: migrate scalar functions (datetime) documentation 2/2 #13921
Conversation
Something wrong here, looks like doc macros is not working in this PR |
Looks like the doc macros doesn't work for this PR for some functions |
| 2023-01-31 | | ||
+-----------------------------+ | ||
+-------------------------------+ | ||
| to_date(Utf8(\"2023-01-31\")) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the slash is not needed
| 2023-01-31 | | ||
+---------------------------------------------------------------+ | ||
+---------------------------------------------------------------------+ | ||
| to_date(Utf8(\"2023/01/31\"),Utf8(\"%Y-%m-%d\"),Utf8(\"%Y/%m/%d\")) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
I think we are very close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @Chen-Yuan-Lai 1 done some more to go :)
Which issue does this PR close?
Part of #13671 .
Rationale for this change
What changes are included in this PR?
As discussed in #13671 , this PR will migrate the parts of builtin datetime functions documentation that currently support migration.
Are these changes tested?
Are there any user-facing changes?