-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Java expansion service to use distroless #33464
Conversation
R: @chamikaramj |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Failing workflow (windows java tests) is currently permared, likely an image issue |
LGTM. Thanks! |
Looks like maybe they aren't keeping this image up to date then? https://pantheon.corp.google.com/artifacts/docker/distroless/us/gcr.io/java?e=13802955&mods=-ai_platform_fake_service |
gcr.io/distroless/java:11 appears to use old system and java versions. There are multiple vulneribilities come from OS and openjdk. The original gcr repository does not have vulnerability scan enabled. However, doing a pull then push to a repo that enabled vulnerability scan indeed reports multiple vulneribilities: gcr.io/google.com/clouddfe/yathu/distroless/java:11 |
Yeah, agreed - I'm going to revert here, seems like this is not a viable path unless we upgrade our java version (not sure if that will help or not) |
This will drive down the number of vulnerabilities in this container and the expansion container shouldn't be relying on other things here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.