Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java expansion service to use distroless #33464

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

damccorm
Copy link
Contributor

This will drive down the number of vulnerabilities in this container and the expansion container shouldn't be relying on other things here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Dec 30, 2024
@damccorm damccorm marked this pull request as ready for review December 30, 2024 17:07
@damccorm
Copy link
Contributor Author

R: @chamikaramj

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm
Copy link
Contributor Author

damccorm commented Dec 30, 2024

Failing workflow (windows java tests) is currently permared, likely an image issue

@chamikaramj
Copy link
Contributor

LGTM. Thanks!

@damccorm damccorm merged commit 669076a into master Dec 30, 2024
17 of 19 checks passed
@damccorm damccorm deleted the users/damccorm/distrolessExpansion branch December 30, 2024 19:38
@Abacn
Copy link
Contributor

Abacn commented Jan 2, 2025

the switch somehow introduced more vulneribility alerts

image

@damccorm
Copy link
Contributor Author

damccorm commented Jan 2, 2025

the switch somehow introduced more vulneribility alerts

image

Looks like maybe they aren't keeping this image up to date then? https://pantheon.corp.google.com/artifacts/docker/distroless/us/gcr.io/java?e=13802955&mods=-ai_platform_fake_service

@Abacn
Copy link
Contributor

Abacn commented Jan 2, 2025

gcr.io/distroless/java:11 appears to use old system and java versions. There are multiple vulneribilities come from OS and openjdk. The original gcr repository does not have vulnerability scan enabled. However, doing a pull then push to a repo that enabled vulnerability scan indeed reports multiple vulneribilities:

gcr.io/google.com/clouddfe/yathu/distroless/java:11

@damccorm
Copy link
Contributor Author

damccorm commented Jan 2, 2025

gcr.io/distroless/java:11 appears to use old system and java versions. There are multiple vulneribilities come from OS and openjdk. The original gcr repository does not have vulnerability scan enabled. However, doing a pull then push to a repo that enabled vulnerability scan indeed reports multiple vulneribilities:

gcr.io/google.com/clouddfe/yathu/distroless/java:11

Yeah, agreed - I'm going to revert here, seems like this is not a viable path unless we upgrade our java version (not sure if that will help or not)

@Abacn
Copy link
Contributor

Abacn commented Jan 2, 2025

it appears the repo has renamed to gcr.io/distroless/java11. The latest one has fewer vulnerabilities:

image

@damccorm
Copy link
Contributor Author

damccorm commented Jan 2, 2025

it appears the repo has renamed to gcr.io/distroless/java11. The latest one has fewer vulnerabilities:

image

I'm still inclined to revert since I think that is still worse than our current base

damccorm added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants