-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Managed Iceberg] refactor integration tests; make it easy to add a new catalog to test suite #33444
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like it
Taking care of some tech-debt here.
Adding a top-level abstract base test class that defines integration tests for Managed Iceberg using a generic catalog.
To add a new catalog and run the integration tests against it, we just have to create a subclass and implement code for the following:
and potentially additional code for setup and cleanup.
See examples in HadoopCatalogIT and HiveCatalogIT for reference