Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Managed Iceberg] refactor integration tests; make it easy to add a new catalog to test suite #33444

Merged
merged 8 commits into from
Dec 28, 2024

Conversation

ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented Dec 23, 2024

Taking care of some tech-debt here.

Adding a top-level abstract base test class that defines integration tests for Managed Iceberg using a generic catalog.

To add a new catalog and run the integration tests against it, we just have to create a subclass and implement code for the following:

  • creating the catalog
  • providing the Managed Iceberg config

and potentially additional code for setup and cleanup.

See examples in HadoopCatalogIT and HiveCatalogIT for reference

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @damccorm for label build.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it

@ahmedabu98 ahmedabu98 merged commit 0dc2c24 into apache:master Dec 28, 2024
23 checks passed
@ahmedabu98 ahmedabu98 mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants