Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3957: [C] Fix typos in docs and examples #2795

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

SahilKang
Copy link
Contributor

What is the purpose of the change

This fixes typos in docs and examples

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

No new features are added

@github-actions github-actions bot added the C label Mar 10, 2024
Signed-off-by: Sahil Kang <[email protected]>
Signed-off-by: Sahil Kang <[email protected]>
This removes the following warning:

  avro/lang/c/examples/quickstop.c:123:40: warning: incompatible pointer types passing 'int32_t **' (aka 'int **') to parameter of type
        'const char **' [-Wincompatible-pointer-types]
                          avro_value_get_string(&first_value, &p, &size);

Signed-off-by: Sahil Kang <[email protected]>
Signed-off-by: Sahil Kang <[email protected]>
@SahilKang SahilKang changed the title AVRO-3954: [C] Fix typos in docs and examples AVRO-3957: [C] Fix typos in docs and examples Mar 10, 2024
Copy link
Contributor

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-g martin-g merged commit 52f051d into apache:main Mar 11, 2024
5 checks passed
@martin-g
Copy link
Member

Thank you, @SahilKang !

@SahilKang SahilKang deleted the c-typos branch April 20, 2024 05:51
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
* AVRO-3957: [C] Fix misformatted type in docs

Signed-off-by: Sahil Kang <[email protected]>
Signed-off-by: Sahil Kang <[email protected]>

* AVRO-3957: [C] Fix type in quickstop example

This removes the following warning:

  avro/lang/c/examples/quickstop.c:123:40: warning: incompatible pointer types passing 'int32_t **' (aka 'int **') to parameter of type
        'const char **' [-Wincompatible-pointer-types]
                          avro_value_get_string(&first_value, &p, &size);

Signed-off-by: Sahil Kang <[email protected]>
Signed-off-by: Sahil Kang <[email protected]>

---------

Signed-off-by: Sahil Kang <[email protected]>
Signed-off-by: Sahil Kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants