Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert custom attribute to string #2547

Closed
wants to merge 1 commit into from
Closed

convert custom attribute to string #2547

wants to merge 1 commit into from

Conversation

artpaul
Copy link

@artpaul artpaul commented Oct 11, 2023

additional attributes may be of any type, so we should convert value to string instead of read it as a string type.

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

additional attributes may be of any type, so we should convert
value to string instead of read it as a string type.
@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Oct 11, 2023
@KalleOlaviNiemitalo
Copy link
Contributor

Having the map contain JSON values encoded as strings was suggested in #1736 (comment).

This is a breaking change. Please add or update tests for non-string values in custom attributes.

Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is no JIRA ticket
  2. The PR template is completely ignored

@artpaul artpaul closed this by deleting the head repository Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants