Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45096: [C++] Apply a cstdint patch to bundled Thrift for GCC 15 #45097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kou
Copy link
Member

@kou kou commented Dec 23, 2024

Rationale for this change

Apache Thrift misses #include <cstdint> for int64_t: apache/thrift#3078
GCC 15 requires it.

What changes are included in this PR?

Apply apache/thrift#3078 only with GCC 15.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #45096 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me. @jonkeane do you want to validate it?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants