-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: make it easier to find fix instructions when cargo fmt
on parquet fails
#6886
Conversation
This reverts commit 440e520.
2c28558
to
3da1765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Nice. Just a small correction.
Co-authored-by: Ed Seidl <[email protected]>
Nice catch -- thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we have such an arcane incantation?
In particular, things like Lines 137 to 138 in 54dccad
cargo fmt . I agree the incantation is not desirable, and was meant to be a stop-gap until a better solution can be found.
|
Filed #6897 to track |
Which issue does this PR close?
Closes #.
Rationale for this change
While working on #6840 the
fmt
ci check failed on parquet. For example: https://github.com/apache/arrow-rs/actions/runs/12361198145/job/34497838320However, the exact recipe to fix this was not clear (you have to run a certain command within the arquet directory)
What changes are included in this PR?
Example https://github.com/apache/arrow-rs/actions/runs/12361621609/job/34499177568?pr=6886
Are there any user-facing changes?