should fail

apache · Dec 9, 2024 · 9839874 · 9839874
1 parent 5dadb25
commit 9839874
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/object_store/src/aws/client.rs b/object_store/src/aws/client.rs
@@ -676,7 +676,7 @@ impl S3Client {
             request = request.with_encryption_headers();
         }
         let response = request.send().await?;
-        let checksum = response
+        let checksum_sha256 = response
             .headers()
             .get(SHA256_CHECKSUM)
             .and_then(|v| v.to_str().ok())
@@ -696,7 +696,10 @@ impl S3Client {
         };
 
         let content_id = if self.config.checksum == Some(Checksum::SHA256) {
-            let meta = PartMetadata { e_tag, checksum };
+            let meta = PartMetadata {
+                e_tag,
+                checksum_sha256,
+            };
             quick_xml::se::to_string(&meta).unwrap()
         } else {
             e_tag

diff --git a/object_store/src/client/s3.rs b/object_store/src/client/s3.rs
@@ -110,7 +110,7 @@ pub(crate) struct CompleteMultipartUpload {
 pub(crate) struct PartMetadata {
     pub e_tag: String,
     #[serde(skip_serializing_if = "Option::is_none")]
-    pub checksum: Option<String>,
+    pub checksum_sha256: Option<String>,
 }
 
 impl From<Vec<PartId>> for CompleteMultipartUpload {
@@ -124,13 +124,13 @@ impl From<Vec<PartId>> for CompleteMultipartUpload {
                     // fallback to old way
                     Err(_) => PartMetadata {
                         e_tag: part.content_id.clone(),
-                        checksum: None,
+                        checksum_sha256: None,
                     },
                 };
                 MultipartPart {
                     e_tag: md.e_tag,
                     part_number: part_idx + 1,
-                    checksum_sha256: md.checksum,
+                    checksum_sha256: md.checksum_sha256,
                 }
             })
             .collect();