Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated log level from error to debug in recordStatus in apisix_upstream.go #2306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sreeram-venkitesh
Copy link

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Fixes #2260. Based on the comment #2260 (comment), I've updated one of the error logs to debug level. I was not able to reproduce the error logs given by @ikatlinski locally though. I tried creating both Routes and Upstream objects.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@sreeram-venkitesh
Copy link
Author

@Revolyssup @pottekkat: I'd love some guidance on how I can take this forward. Currently in the PR I've only updated a single log line which was mentioned as for sure not an error and warn, but rather info or debug in #2260.

Copy link

github-actions bot commented Dec 8, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: inconsistent messages are should in logs when new route/upstream is registred
1 participant