Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Rewrite Header Annotations #2285

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mpoqq
Copy link

@mpoqq mpoqq commented Aug 26, 2024

Type of change:

  • New feature provided

What this PR does / why we need it:

Pre-submission checklist:

Implements #2284
Adds Rewrite Add/Set/Remove Header annotations.

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@mpoqq mpoqq force-pushed the change-2284-rewrite-headers branch from c6eb07d to 3eea3f4 Compare August 26, 2024 15:04
@mpoqq
Copy link
Author

mpoqq commented Sep 2, 2024

I am unable to reproduce the failure of the e2e test locally. Does somebody has an idea why the test fails (maybe flaky)?

@mpoqq
Copy link
Author

mpoqq commented Oct 7, 2024

@pottekkat Can I do anything that the PR will be reviewed?

@Revolyssup
Copy link
Contributor

@mpoqq Can you fix one failing lint check?

@mpoqq
Copy link
Author

mpoqq commented Oct 7, 2024

@mpoqq Can you fix one failing lint check?

@Revolyssup I would like to do that, but the lint errors are the same as in the main branch. They should probably be fixed in a separate PR.

@Revolyssup
Copy link
Contributor

@mpoqq Can you fix one failing lint check?

@Revolyssup I would like to do that, but the lint errors are the same as in the main branch. They should probably be fixed in a separate PR.

Got it.

@Revolyssup
Copy link
Contributor

I will leave a review by the evening.

@mpoqq
Copy link
Author

mpoqq commented Oct 22, 2024

@Revolyssup Friendly Reminder 😛

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants