Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update http[].match.exprs any -> all #2270

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

acuteaura
Copy link
Contributor

Internal testing and the upstream docs seem to indicate that vars in APISIX with multiple matchers requires all of them to return true for the route to match, not any.

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 29, 2024
Copy link

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Oct 30, 2024
@acuteaura
Copy link
Contributor Author

@oil-oil could you have a look?

@juzhiyuan juzhiyuan reopened this Nov 7, 2024
@juzhiyuan juzhiyuan requested a review from moonming November 7, 2024 11:46
@juzhiyuan juzhiyuan removed the stale label Nov 7, 2024
@moonming moonming merged commit 8d33cf0 into apache:master Nov 8, 2024
52 of 54 checks passed
@moonming
Copy link
Member

moonming commented Nov 8, 2024

@acuteaura thanks for your PR

@acuteaura acuteaura deleted the patch-1 branch November 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants