Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deletion of references #2213

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: deletion of references #2213

merged 1 commit into from
Apr 16, 2024

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Apr 15, 2024 •
edited
Loading

After adding the force=true flag in requests to apisix, we cant rely on apisix reference counting to not delete resources and will have to check it at ingress level before sending request to apisix.

Screenshot 2024-04-15 at 3 21 32 PM

How to test

  1. Create a route1 referencing a service
  2. Check that an upstream is created in APISIX.
  3. Create another route, route2 referencing the same service.
  4. Delete route1.
  5. Check APISIX to see that the upstream is not deleted.
  6. Delete route2
  7. Upstream is deleted.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Revolyssup Revolyssup requested a review from AlinsRan April 15, 2024 10:04
@Revolyssup Revolyssup merged commit aba75eb into apache:master Apr 16, 2024
79 checks passed
@Revolyssup Revolyssup deleted the revolyssup/fixdeletionofreferences branch April 16, 2024 06:53
@Revolyssup Revolyssup restored the revolyssup/fixdeletionofreferences branch April 16, 2024 06:56
Revolyssup added a commit to Revolyssup/apisix-ingress-controller that referenced this pull request Apr 16, 2024
@Revolyssup
fix: deletion of references (apache#2213)
8931b6a
Revolyssup added a commit that referenced this pull request Apr 16, 2024
@Revolyssup
fix: backport fix of deletion of references (#2214)
454032c 
* fix: deletion of references (#2213)

* chore: add fix commit in release note

Signed-off-by: Ashish Tiwari <[email protected]>

---------

Signed-off-by: Ashish Tiwari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlinsRan AlinsRan AlinsRan approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revolyssup @nic-6443 @AlinsRan