Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Improvements for vector tiles #8

Merged
merged 11 commits into from
May 19, 2020
Merged

Improvements for vector tiles #8

merged 11 commits into from
May 19, 2020

Conversation

FObermaier
Copy link
Contributor

@FObermaier FObermaier commented Feb 19, 2020 •
edited
Loading

  • Add support for reading missing geometry types
  • Add MapboxTileReader class
  • Add unit tests

relates to #6, #7, #2

@FObermaier
Improve MapboxTileWriter ...
bca563f 
... to write polygons and multi-geometries. Additionally
* Add TileGeometryTransform struct to help with coordinate transfromation
* Add MapboxCommandType enumeration for better readability
* Improve DictionaryExtensions to make key generic
@FObermaier
Add initial MapboxTileReader class
1058f68
@FObermaier
Add round-trip unit test with bug-fixes
52c8e67
@FObermaier FObermaier requested a review from xivk February 19, 2020 20:01
@FObermaier
Copy link
Contributor Author

@xivk, any chance you can take a look at this soon?
I'd like to homogenize wording in function names.

@HarelM
Copy link
Contributor

HarelM commented May 19, 2020

What's the status of this? Can this be merged? Is there a Nuget package one can use?
I would like to generate MBTiles either on the fly in memory in C# or to a file for caching.
Both options probably need this library...
I'd like to help out testing and in case I see that something is missing to add it.
Maybe it's time to move this to NTS to allow more contributor to improve this?
Two month for a pull request is a bit too much for my taste...

@xivk xivk merged commit d3a3e6c into anyways-open:develop May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xivk xivk Awaiting requested review from xivk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FObermaier @HarelM @xivk