perf: optimize performance when disable animation #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Dec 19, 2024
Aarebecca
commented
- 优化禁用动画场景下的性能
- 跳过非必须的样式拷贝
- 更新主题类型
Walkthrough此PR优化了在禁用动画时的性能，避免了不必要的样式深拷贝，并更新了主题类型以支持布尔值。通过这些改进，减少了不必要的计算和内存使用。 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| const { stage = 'enter' } = context; | ||
| const { stage = 'enter', animation } = context; | ||
|
|
||
| const enableAnimation = animation && this.context.options.animation; |
There was a problem hiding this comment.
The introduction of enableAnimation is a good optimization to prevent unnecessary deep copying of styles when animation is disabled. This change should help in reducing memory usage and improving performance.
|
这个优化了多少～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.