Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes memory leaks caused by the StaticData objects associated with the generated Parser and Lexer classes.
Found using the CRT library in VS2022. With the demo project, it produces a leak report similar to this:
Valgrind on Ubuntu produces a similarly large leak detection.
Switching the StaticData objects to be unique_ptr instead of raw pointers removes all but 1 leak.
The remaining leak is the ATNDeserializationOptions which is also fixed by a unique_ptr.