Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New hash set #4550

Merged
merged 2 commits into from
Mar 11, 2024
Merged

New hash set #4550

merged 2 commits into from
Mar 11, 2024

Conversation

ericvergnaud
Copy link
Contributor

@ericvergnaud ericvergnaud commented Mar 8, 2024 •
edited
Loading

Uses an optimized HashSet

@ericvergnaud
add test spec for HashSet
d571d65 
Signed-off-by: Eric Vergnaud <[email protected]>
@ericvergnaud
improve HashSet performance
bf8dc1b 
Signed-off-by: Eric Vergnaud <[email protected]>
@ericvergnaud ericvergnaud requested a review from kaby76 March 8, 2024 19:34
@ericvergnaud
Copy link
Contributor Author

ignore the unrelated failing php build

@ericvergnaud ericvergnaud mentioned this pull request Mar 8, 2024
Closed
@kaby76
Copy link
Contributor

kaby76 commented Mar 10, 2024

Here's the performance of this PR. The performance increased 14% (4.13.1 TS at 2.8396 , SD 0.014; PR TS at 2.4940, SD 0.933).

java

@ericvergnaud
Copy link
Contributor Author

That's great!

@kaby76
Copy link
Contributor

kaby76 commented Mar 10, 2024

All grammars in grammars-v4 pass this PR.

@ericvergnaud ericvergnaud merged commit 1f5e64b into antlr:dev Mar 11, 2024
40 of 42 checks passed
@ericvergnaud ericvergnaud deleted the new-hash-set branch March 11, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaby76 kaby76 kaby76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericvergnaud @kaby76