Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File stats wrapped in result #53

Merged
merged 2 commits into from
Nov 23, 2024
Merged

File stats wrapped in result #53

merged 2 commits into from
Nov 23, 2024

Conversation

antiguru
Copy link
Owner

@antiguru antiguru commented Nov 5, 2024

Instead of printing the I/O error within the crate, encapsulate the file stats with a result that forwards the error. This avoids printing errors for clients where it's expected the stats cannot be collected.

Instead of printing the I/O error within the crate, encapsulate the file
stats with a result that forwards the error. This avoids printing errors
for clients where it's expected the stats cannot be collected.

Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru merged commit f12fb6d into main Nov 23, 2024
5 checks passed
@antiguru antiguru deleted the stats_error_handling branch November 23, 2024 12:19
@github-actions github-actions bot mentioned this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant