Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "docs: add GPT-Vis demo for bubble" #281

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 30, 2024

Reverts #278

Summary by CodeRabbit

  • 新功能

    • 在 Bubble 组件的文档中新增了使用 GPT-Vis 渲染图表的示例代码。
  • 文档

    • 移除了与 GPT-Vis 渲染相关的中文和英文文档。
    • 更新了英文文档,增加了 GPT-Vis 示例代码。
    • 中文文档中删除了 GPT-Vis 渲染的示例代码。
  • 依赖项

    • 从开发依赖中移除了 @antv/gpt-vis
  • 测试

    • 更新了测试文件,移除了对 'gpt-vis' 演示的跳过选项。

Copy link
Contributor

coderabbitai bot commented Nov 30, 2024

📝 Walkthrough

Walkthrough

本次提交主要涉及对多个文件的修改,重点是移除与@antv/gpt-vis库相关的内容和配置。具体而言,.dumirc.ts文件中删除了externals属性,gpt-vis.mdgpt-vis.tsx文件被完全移除,测试文件中取消了对gpt-vis演示的跳过选项。此外,package.json中也移除了对@antv/gpt-vis的依赖。文档文件index.en-US.md添加了新的示例,而index.zh-CN.md则删除了相关示例。

Changes

文件路径 更改摘要
.dumirc.ts 删除了externals属性。
components/bubble/__tests__/demo-extend.test.ts 更新了extendTest函数调用,移除了跳过选项。
components/bubble/__tests__/demo.test.ts 更新了demoTest函数调用,移除了跳过选项。
components/bubble/demo/gpt-vis.md 完全删除了该文件。
components/bubble/demo/gpt-vis.tsx 完全删除了该文件,包含了App组件。
components/bubble/index.en-US.md 在“Examples”部分添加了使用GPT-Vis渲染图表的新示例代码。
components/bubble/index.zh-CN.md 删除了展示GPT-Vis渲染的代码示例。
package.json devDependencies中移除了对@antv/gpt-vis的依赖。

Possibly related PRs

  • docs: add GPT-Vis demo for bubble #278: 本次PR涉及在.dumirc.ts中删除externals属性,与添加@antv/gpt-vis依赖及引入使用GPT-Vis的Bubble组件演示的PR相关。两者都关注于GPT-Vis在项目中的集成和配置。

Suggested reviewers

  • YumoImer

Poem

在草地上跳跃的小兔子,
移除依赖,清理无用的痕迹。
示例更新,功能更明晰,
代码简洁,未来更美丽!
一起欢庆,新的开始,
小兔子乐在其中,真开心! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9ddf51c and c952946.

📒 Files selected for processing (8)
  • .dumirc.ts (0 hunks)
  • components/bubble/__tests__/demo-extend.test.ts (1 hunks)
  • components/bubble/__tests__/demo.test.ts (1 hunks)
  • components/bubble/demo/gpt-vis.md (0 hunks)
  • components/bubble/demo/gpt-vis.tsx (0 hunks)
  • components/bubble/index.en-US.md (0 hunks)
  • components/bubble/index.zh-CN.md (0 hunks)
  • package.json (0 hunks)
💤 Files with no reviewable changes (6)
  • components/bubble/index.zh-CN.md
  • components/bubble/demo/gpt-vis.md
  • components/bubble/index.en-US.md
  • package.json
  • .dumirc.ts
  • components/bubble/demo/gpt-vis.tsx
🔇 Additional comments (2)
components/bubble/__tests__/demo.test.ts (1)

3-3: 移除 skip 选项的修改正确!

由于 GPT-Vis 相关的演示已被移除,删除跳过测试选项是合理的修改。代码变更与 PR 的目标保持一致。

components/bubble/__tests__/demo-extend.test.ts (1)

3-3: 测试配置更新正确!

移除 GPT-Vis 相关的跳过选项与 demo.test.ts 的修改保持一致,符合移除 GPT-Vis 演示的整体目标。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 30, 2024

Preview is ready

Copy link

codecov bot commented Nov 30, 2024

Bundle Report

Bundle size has no change ✅

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 22.7 MB typescript-bot

🚮 Removed packages: npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@babel/[email protected], npm/@biomejs/[email protected], npm/@codecov/[email protected], npm/@codesandbox/[email protected], npm/@ctrl/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@happy-dom/[email protected], npm/@ianvs/[email protected], npm/@madccc/[email protected], npm/@microflash/[email protected], npm/@npmcli/[email protected], npm/@octokit/[email protected], npm/@qixian.cs/[email protected], npm/@rc-component/[email protected], npm/@rc-component/[email protected], npm/@size-limit/[email protected], npm/@stackblitz/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@umijs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

Deploying ant-design-x with  Cloudflare Pages  Cloudflare Pages

Latest commit: c952946
Status: ✅  Deploy successful!
Preview URL: https://8c3e6081.ant-design-x.pages.dev
Branch Preview URL: https://revert-278-docs-gpt-vis.ant-design-x.pages.dev

View logs

Copy link

size-limit report 📦

Path Size
dist/antdx.min.js 40.53 KB

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (9ddf51c) to head (c952946).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          66       66           
  Lines        1422     1422           
  Branches      379      364   -15     
=======================================
  Hits         1296     1296           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 enabled auto-merge (squash) November 30, 2024 14:45
@afc163 afc163 merged commit 8ffbef6 into main Nov 30, 2024
16 checks passed
@afc163 afc163 deleted the revert-278-docs/gpt-vis branch November 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants