Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notice bar close and not propagate #6564

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damonyoungcc
Copy link
Collaborator

@damonyoungcc damonyoungcc commented Mar 2, 2024

close #6559

@damonyoungcc damonyoungcc requested a review from zombieJ March 2, 2024 15:16
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (784eff5) to head (a0b66b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6564   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         318      318           
  Lines        6910     6910           
  Branches     1729     1729           
=======================================
  Hits         6381     6381           
  Misses        493      493           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6564.surge.sh

@damonyoungcc
Copy link
Collaborator Author

这里我本来是想在调用 onClose前添加一行阻止冒泡的代码,考虑到不造成break change,就把event透传出来给用户了,让用户决定,同时也完善了 onClickTS类型

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoticeBar同时设置onClick closeable,点击关闭会冒泡到onClick,期望阻止closeable冒泡
1 participant