Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - filter invalid pp #5

Merged
merged 1 commit into from
Jun 24, 2024
Merged

NOISSUE - filter invalid pp #5

merged 1 commit into from
Jun 24, 2024

Conversation

olekans
Copy link
Contributor

@olekans olekans commented Jun 13, 2024

AC

  • ...

@olekans olekans marked this pull request as ready for review June 13, 2024 06:59
@olekans olekans changed the title NOISSUE - filter test pp NOISSUE - filter invalid pp Jun 13, 2024
Wiktor6
Wiktor6 reviewed Jun 13, 2024
View reviewed changes
src/Service/ParcelShopsService.php Outdated
@@ -49,13 +49,21 @@ public function getParcelShopCollection(

$parcelShopCollection = [];
foreach ($rawParcelShopCollection as $rawParcelShop) {
if (isset($parcelShopCollection[$rawParcelShop->pclshopid])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you are doing this in some context. But this should not be an library responsibility to check if id's are unique.

Wiktor6
Wiktor6 reviewed Jun 13, 2024
View reviewed changes
src/Service/ParcelShopsService.php Outdated
continue;
}

if (null === $rawParcelShop->geolat || null === $rawParcelShop->geolng) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as above.

@olekans olekans requested a review from Wiktor6 June 13, 2024 08:57
@olekans olekans force-pushed the NOISSUE-handle-nullable-iscodhandler-ok branch from 592a023 to aeb9a6e Compare June 13, 2024 09:26
@olekans olekans merged commit fe8491f into master Jun 24, 2024
7 checks passed
@olekans olekans deleted the NOISSUE-handle-nullable-iscodhandler-ok branch June 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradkozaczenko konradkozaczenko konradkozaczenko approved these changes

@Wiktor6 Wiktor6 Wiktor6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olekans @Wiktor6 @konradkozaczenko